Points of Required Attention™
Please chime in on a proposed restructuring of the ROM hacking sections.
Views: 88,496,746
Main | FAQ | Uploader | IRC chat | Radio | Memberlist | Active users | Latest posts | Calendar | Stats | Online users | Search 04-28-24 03:48 PM
Guest: Register | Login

0 users currently in Help/Suggestions/Bug Reports | 2 guests

Main - Help/Suggestions/Bug Reports - Post Layouts, Javascript, CSS and IE <7 New thread | New reply

Pages: 1 2

lukegb
Posted on 02-22-10 01:56 AM Link | Quote | ID: 127418

Newcomer
Level: 5

Posts: 1/3
EXP: 373
Next: 156

Since: 02-22-10

Last post: 5179 days
Last view: 5179 days
View this post in a version of IE previous to or including 7 (or 8, in compatibility mode) and you'll see what I mean.

Danke.

blackhole89
Posted on 02-22-10 02:01 AM (rev. 2 of 02-22-10 02:04 AM) Link | Quote | ID: 127419


The Guardian
Moloch whose eyes are a thousand blind windows!
Level: 124

Posts: 2907/4196
EXP: 21536722
Next: 299879

Since: 02-19-07
From: Ithaca, NY, US

Last post: 473 days
Last view: 86 days



Do you really need to create a new account for that?(Assuming this was also you.)

Anyway, while this is a security non-issue (as stolen cookies from this board are generally worthless), thanks for pointing the expression thing out. I'll add something to filter it out tomorrow.

Why do they keep coming up with more and more oddball code execution paths?

____________________



lukegb
Posted on 02-22-10 02:25 AM Link | Quote | ID: 127425

Newcomer
Level: 5

Posts: 2/3
EXP: 373
Next: 156

Since: 02-22-10

Last post: 5179 days
Last view: 5179 days


No, that wasn't me.

I'll change it to do something better then.

blackhole89
Posted on 02-22-10 02:30 AM Link | Quote | ID: 127426


The Guardian
Moloch whose eyes are a thousand blind windows!
Level: 124

Posts: 2908/4196
EXP: 21536722
Next: 299879

Since: 02-19-07
From: Ithaca, NY, US

Last post: 473 days
Last view: 86 days



Sigh, applied a quick and dirty patch to it.

Things like this really make me think we should add some proper rudimentary parser into the post filter rather than just dropping the str_replace hammer on such issues...

____________________



lukegb
Posted on 02-22-10 02:46 AM Link | Quote | ID: 127429

Newcomer
Level: 5

Posts: 3/3
EXP: 373
Next: 156

Since: 02-22-10

Last post: 5179 days
Last view: 5179 days
Posted by blackhole89
Sigh, applied a quick and dirty patch to it.

Things like this really make me think we should add some proper rudimentary parser into the post filter rather than just dropping the str_replace hammer on such issues...


Yeah, you should

Mega-Mario
Posted on 02-22-10 01:49 PM (rev. 2 of 02-22-10 01:50 PM) Link | Quote | ID: 127439

Spamming from alt accounts.
Level: 81

Posts: 666/1610
EXP: 4881064
Next: 111785

Since: 09-10-08

Last post: 3591 days
Last view: 3011 days
Or can't we just go and make the board unusable under IE<7?

Because IE6 is the vulnerability. Seriously why does it let you do things like <img src="javascript:alert('foo');">??

____________________
Kafuka -- ROM hacking
Kuribo64 -- we hack shit

GreyMaria
Posted on 02-22-10 04:20 PM Link | Quote | ID: 127445

>implying even the Japanese understand the Japanese
Level: 105

Posts: 1876/2851
EXP: 11922951
Next: 339309

Since: 07-13-07

Last post: 4499 days
Last view: 4469 days
Bad practice, and Microsoft, respectively.

____________________
we're currently experiencing some technical difficulties

Mega-Mario
Posted on 02-22-10 10:14 PM (rev. 3 of 02-22-10 10:19 PM) Link | Quote | ID: 127461

Spamming from alt accounts.
Level: 81

Posts: 670/1610
EXP: 4881064
Next: 111785

Since: 09-10-08

Last post: 3591 days
Last view: 3011 days
But wait, that's even worse than the <img> trick...

The W3Schools website says that the width property can be either inherited, auto, a percentage or a length in px/cm/etc...

That seems like yet another IE-specific crap... serisouly... why does Micro$oft always bother adding nonstandard crap in their browser rather than making it respect CSS standards? It's just a waste of time, because noone is ever going to use that crap because they know it will only work under IE!

And I wasted my 666th post...

Edit- there's another problem. This one issue might be hard to filter because it can be in an external stylesheet (like it's the case here). It'd require opening the stylesheet in question and removing its inclusion if it contains JS.

____________________
Kafuka -- ROM hacking
Kuribo64 -- we hack shit

Cellar Dweller
Posted on 02-22-10 11:10 PM Link | Quote | ID: 127463


Snifit
Level: 39

Posts: 196/287
EXP: 385254
Next: 19517

Since: 02-19-07
From: Arkansas

Last post: 4054 days
Last view: 3221 days
Posted by lukegb
Posted by blackhole89
Things like this really make me think we should add some proper rudimentary parser into the post filter rather than just dropping the str_replace hammer on such issues...


Yeah, you should


I suggested using a validating parser way back during I2.

Speaking of the filtering code, an updated version of PHP is in the Debian security archive that fixes a recently disclosed bug in htmlspecialchars() that can be used to dodge some of the filtering by using overlong forms of multibyte characters. This got me thinking that all of the regex based filtering used by all versions of AcmlmBoard are vulnerable to the same kind of attack.

Posted by Mega-Mario
there's another problem. This one issue might be hard to filter because it can be in an external stylesheet (like it's the case here). It'd require opening the stylesheet in question and removing its inclusion if it contains JS.


That won't work, as a clean stylesheet could be used until it has been checked. After that, the stylesheet could be replaced with a dirty one. Also, the server hosting it could be configured to serve different versions depending on where the request is coming from.

blackhole89
Posted on 02-22-10 11:12 PM Link | Quote | ID: 127464


The Guardian
Moloch whose eyes are a thousand blind windows!
Level: 124

Posts: 2910/4196
EXP: 21536722
Next: 299879

Since: 02-19-07
From: Ithaca, NY, US

Last post: 473 days
Last view: 86 days



Yeah, this is actually fairly problematic; the best we can do is either banning external stylesheets (which people will slaughter us for) or just forcing anyone with power to not use them.

Does this problem affect decent browsers too or is this only something IE has come up with?

____________________



Mega-Mario
Posted on 02-23-10 12:19 AM Link | Quote | ID: 127470

Spamming from alt accounts.
Level: 81

Posts: 671/1610
EXP: 4881064
Next: 111785

Since: 09-10-08

Last post: 3591 days
Last view: 3011 days
Posted by blackhole89
banning external stylesheets

NO!



Another alternative would require the board to download the stylesheet, look for JS in it and remove its inclusion if there's any. But that'd be tricky.

Posted by blackhole89
Does this problem affect decent browsers too or is this only something IE has come up with?

No, it doesn't affect decent CSS-compliant browsers, of course. It only affects IE because Micro$oft always comes up with nonstandard crap that makes their browser and everything vulnerable

____________________
Kafuka -- ROM hacking
Kuribo64 -- we hack shit

MapleMario
Posted on 02-23-10 04:10 AM Link | Quote | ID: 127475


Red Koopa
Level: 27

Posts: 45/126
EXP: 111455
Next: 4704

Since: 04-28-07
From: USA

Last post: 5071 days
Last view: 3890 days
Can you take a look at the usage stats of board2? If IE6 is sufficiently low (which I assume it is, since this is largely a community of smart people), you could probably just put a huge warning at the top using a conditional comment for IE6 that warns users about possible security holes when using IE6.

____________________


SGMB3 is now being developed with Reuben. Hopefully v1.0 will be released by the time I get world 1 done...

- Layout: MM v0.31




Kawa
Posted on 02-23-10 06:59 PM Link | Quote | ID: 127493


CHIKKN NI A BAAZZKIT!!!
80's Cheerilee is best pony
Level: 138

Posts: 3288/5344
EXP: 30950303
Next: 712678

Since: 02-20-07
From: The Netherlands

Last post: 4500 days
Last view: 2635 days
Posted by MapleMario
Can you take a look at the usage stats of board2? If IE6 is sufficiently low (which I assume it is, since this is largely a community of smart people), you could probably just put a huge warning at the top using a conditional comment for IE6 that warns users about possible security holes when using IE6.
An excellent idea, MapleMario. However, I would suggest the following changes:
1) Conditional comments are not required -- this is a PHP site and PHP can sniff out specific browsers just fine.
2) Don't make the warning obnoxiously large, cos that will only make you look like a total dick.
3) Disable postlayouts altogether if you detect IE6 or lower to actually prevent bullshit instead of merely warning about it.

____________________
Wife make lunch - Shampoo
Opera - give it a spin
Spare some of your free time?
<GreyMaria> I walked around the Lake so many goddamn times that my sex drive was brutally murdered
Kawa rocks — byuu

Mega-Mario
Posted on 02-23-10 07:15 PM Link | Quote | ID: 127495

Spamming from alt accounts.
Level: 81

Posts: 673/1610
EXP: 4881064
Next: 111785

Since: 09-10-08

Last post: 3591 days
Last view: 3011 days
Those are all good ideas, Kawa.

Except for the first point, what if the browser is disguising as another browser by a changed user agent? though, I don't think IE can do that...

____________________
Kafuka -- ROM hacking
Kuribo64 -- we hack shit

GreyMaria
Posted on 02-23-10 07:51 PM Link | Quote | ID: 127497

>implying even the Japanese understand the Japanese
Level: 105

Posts: 1878/2851
EXP: 11922951
Next: 339309

Since: 07-13-07

Last post: 4499 days
Last view: 4469 days
Why the hell would you need to disguise as IE6 on a site that works just fine in any reputable browser ever?

____________________
we're currently experiencing some technical difficulties

Kawa
Posted on 02-23-10 07:52 PM Link | Quote | ID: 127498


CHIKKN NI A BAAZZKIT!!!
80's Cheerilee is best pony
Level: 138

Posts: 3289/5344
EXP: 30950303
Next: 712678

Since: 02-20-07
From: The Netherlands

Last post: 4500 days
Last view: 2635 days
Posted by Mega-Mario
though, I don't think IE can do that...
Not to my knowledge, it can't.

____________________
Wife make lunch - Shampoo
Opera - give it a spin
Spare some of your free time?
<GreyMaria> I walked around the Lake so many goddamn times that my sex drive was brutally murdered
Kawa rocks — byuu

Arbe
Posted on 02-23-10 10:52 PM Link | Quote | ID: 127508

go away
Level: 86

Posts: 1766/1788
EXP: 5988392
Next: 153715

Since: 02-23-07

Last post: 4971 days
Last view: 1540 days
this board was written by people with no idea about real security, then maintained by someone who, looking back on the board's history, learned design security from XSS cheat sheets. it'll never be vulnerability free.

blackhole89
Posted on 02-23-10 10:55 PM Link | Quote | ID: 127509


The Guardian
Moloch whose eyes are a thousand blind windows!
Level: 124

Posts: 2913/4196
EXP: 21536722
Next: 299879

Since: 02-19-07
From: Ithaca, NY, US

Last post: 473 days
Last view: 86 days



Well, I dare you find an exploit that enables you to cause actual damage.

____________________



Mega-Mario
Posted on 02-23-10 11:35 PM Link | Quote | ID: 127515

Spamming from alt accounts.
Level: 81

Posts: 677/1610
EXP: 4881064
Next: 111785

Since: 09-10-08

Last post: 3591 days
Last view: 3011 days
Posted by GreyMario
Why the hell would you need to disguise as IE6 on a site that works just fine in any reputable browser ever?

Allright, it'd be a rather bad idea.

Posted by Arbe
this board was written by people with no idea about real security, then maintained by someone who, looking back on the board's history, learned design security from XSS cheat sheets. it'll never be vulnerability free.

Allright. Look at the Acmlmboard source code of 1.x versions. Look at how user input is sanitized before being passed to SQL queries. Strings are addslashes()'d and integers aren't even sanitized! omg.

According to what I can read from the archives, they also didn't know what database backups were for. And when they were getting hacked, they always went "oh, due to an unfortunate event the board has been restored from a 3 year old backup... if some things are missing feel free to ask us "



____________________
Kafuka -- ROM hacking
Kuribo64 -- we hack shit

MapleMario
Posted on 02-23-10 11:47 PM Link | Quote | ID: 127518


Red Koopa
Level: 27

Posts: 51/126
EXP: 111455
Next: 4704

Since: 04-28-07
From: USA

Last post: 5071 days
Last view: 3890 days
Could also use this same hack to make a jQuery call to a PHP page that adds the user's browser to a blacklist of hackable browsers, in case IE6 isn't the only one that does it. Then, like someone suggested, just disable custom stylesheets from those browsers.

____________________


SGMB3 is now being developed with Reuben. Hopefully v1.0 will be released by the time I get world 1 done...

- Layout: MM v0.31



Pages: 1 2


Main - Help/Suggestions/Bug Reports - Post Layouts, Javascript, CSS and IE <7 New thread | New reply

Acmlmboard 2.1+4δ (2023-01-15)
© 2005-2023 Acmlm, blackhole89, Xkeeper et al.

Page rendered in 0.032 seconds. (321KB of memory used)
MySQL - queries: 62, rows: 90/91, time: 0.016 seconds.