put
pre br { display: none; }
in some css file that thread pages use
this is easier than trying to only nl2br() outside of <pre> tags

____________________

 

hmm, but that would remove any instances of <br> that the user intentionally put there for whatever reason (which shouldn't come up in <style> tags, but might come up in <pre> tags, or maybe some other tags where we wouldn't want to nl2br()).

maybe it would be best to try to separate out the post into separate strings, based on what parts are inside specific tags where we don't want to add <br> and what parts aren't, then nl2br() the parts outside those tags, then merge them together again. that would take a bit of work, but shouldn't take too long to figure out. I could give it a try.

but the solution in the OP works as a quick fix to a more specific and common problem.

____________________

 

Posted by Spikeman

---

I'd recommend using some form of regular expression.

---

HEY, GOOD IDEA !

Posted by stag019

---

Yeah, but it would still be beneficial to know how to not nl2br() inside tags,

---

Posted by Xkeeper

---

Just making a way for some tags to not get nl2br'd would be nice...

---

hey look what I made

try it out! I tested it pretty well, but maybe there's some weird cases I didn't think of. it'll probably behave unexpectedly with improperly overlapping tags, but the worst it could do is put
inside one region of one of them, which is not the biggest of your problems if you've got overlapping tags anyway.

edit: okay, fixed
edit: it has been pointed out that this implementation won't work for tables. I might come up with something for that later.

____________________

 

update!

this code produces this output. (the txt file is just the php file, saved as .txt.)

KNOWN ISSUE: this will NOT work with NESTED TABLES - it will behave erratically, possibly breaking up the string around mismatched <td> </td> pairs. this will only come up in the case of bad html, or if a table is INSIDE a table cell, which is almost never useful. the worst possible result is that <br> tags are not inserted in places where they should be and are inserted in places where they shouldn't be. it won't screw up good html. again, this will only come up if there is a table inside another table.

the other tags (<pre> and <style>) work just fine, inside or outside table cells. if you'd like to add more tags, add them to the end of the $tagorder array, following the pattern of the others. if you don't want xhtml-style <br> tags, change the nl2br() line near the bottom to a str_replace or whatever.

____________________